BUGFIX #820 createDrawingShape stopped working in 1.1.0 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setContainer in ShapeCollection::addShape().
|
Ok, I believe the other ci errors are from other commits. CS Fixer has many complaints because of blank_line_after_opening_tag Unit test for Writer\PowerPoint2007 have some changed IDs. I believe that's from replacing the iterator with the for each loop (other commits from v1.1.0). Iteration looks better with the new version. Deploy fails because of unit tests errors. Check samples throws: Not sure about this one. Wasn't me :) |
|
Doh, this does not work. |
kw-pr
added a commit
to kw-pr/PHPPresentation
that referenced
this pull request
Dec 12, 2024
|
I close this PR in favor of the new solution #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setContainer in ShapeCollection::addShape().
Description
Fixes #820 createDrawingShape stopped working in 1.1.0
See #820 (comment) for details.
Checklist:
I think tests and documentation is not needed for this.